search

imc-trading / svlangserver

MIT License
97 stars 13 forks source link

Go to Definition support for duplicate module names. #48

Open haydnevans1 opened 4 months ago

haydnevans1 commented 4 months ago

Hi, really love the extension! I work in a codebase where we often have multiple modules of the same name. The current functionality of the extension seems to just pick the first module it finds of that name. Is it possible to get a list of modules that match the name when using go to Definition?

Thanks.

kkanhere commented 4 months ago

Yep. The language server picks the first match. Since the protocol does support providing multiple targets, I believe this can be supported. Added todo list. Also note that pull requests are always welcome.

haydnevans1 commented 4 months ago

Ok great! Good to know it is very possible, I may make a pull request and give it a go over the weekend.