search

imc-trading / svlangserver

MIT License
100 stars 13 forks source link

Rewrote Verilator diagnostics parser to fix issue #8 #9

Closed chrbirks closed 3 years ago

chrbirks commented 3 years ago

The _splitTerms function was rewritten to use RegEx matching instead of relying on : as separators since newer Verilator versions can report column numbers. Also, some messages can contain colons in the message:

%Error: crc32_8.sv:69: Duplicate declaration of signal: 'plus_one'

Basic error handling was added to skip the diagnostics message in case match returns null.

kkanhere commented 3 years ago

Thanks! Will check this over the weekend.

kkanhere commented 3 years ago

Decided to simplify the parsing by merging ad-hoc conditionals with the regex. Closing this pull-request as these changes have been absorbed in a new one. Thanks for the pull request!