search

imccrum / canviz

Automatically exported from code.google.com/p/canviz
0 stars 0 forks source link

Hardcoded div names graph_texts and graph_container #29

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
We go to the effort of making the canvas graphics context a parameter to the 
Graph initialize() 
method, but then the Graph draw() method references divs named "graph_texts" 
and 
"graph_container". That's not good. It certainly prevents having multiple 
graphs on one page, and 
there's no reason we should prevent that.

Perhaps it would be best to make the caller supply just the name of an empty 
div when making a 
new Graph. Then Canviz would take care of creating the canvas and the text divs 
inside it.

Original issue reported on code.google.com by ryandesi...@gmail.com on 22 Oct 2008 at 9:36

GoogleCodeExporter commented 9 years ago 
Fixed in r168. This revision also caused some more IE problems, but that's to be
dealt with in issue #8.

Original comment by ryandesi...@gmail.com on 29 Oct 2008 at 8:35