search

imcgreer / simqso

Module for generating simulated quasar spectra
BSD 3-Clause "New" or "Revised" License
12 stars 11 forks source link

lyman_alpha rest-frame wavelength #29

Open londumas opened 5 years ago

londumas commented 5 years ago

Doing a simple grep '1215' -r * --include \*.py, I get the following:

hiforest.py:        self.zmin = wave.min() / 1215.7 - 1.01
sqgrids.py:                                       [1215.7])
sqgrids.py:    >>> v = GaussianEmissionLineVar([GaussianSampler(1215.7,0.1),GaussianSampler(100.,10.),GaussianSampler(10.,1.)])
sqgrids.py:    array([[ 1215.645,   113.125,     9.099],
sqgrids.py:           [ 1215.987,   109.654,     9.312],
sqgrids.py:           [ 1215.74 ,   101.765,    10.822]])

Does that mean that the rest-frame wavelength of Lyman-alpha emission line and the definition of zmin is not using lambda_lya = 1215.67 A? but is using 1215.7?

Thanks for the package, it works very well.

londumas commented 5 years ago

@moustakas, Same question applies to the fork https://github.com/moustakas/simqso