imchipwood / dumbpad

Simple 4x4 numpad with rotary encoder. Powered by QMK via ATmega32u4 Pro Micro
GNU General Public License v2.0
373 stars 57 forks source link

Change VENDOR_ID in QMK firmware for proper VIA compatibility #15

Closed mpfl closed 2 years ago

mpfl commented 2 years ago

Theoretically this is an issue to raise in the QMK repo, but I wanted to get your attention.

It looks like the VENDOR_ID for the Dumbpad is still the default of 0xFEED.

Would you be able to change the VENDOR_ID so that I can submit my VIA config to VIA? Alternatively, I would be happy to change the VENDOR_ID and submit a PR. Figure it would be polite to ask you first since you're the Dumbpad's creator!

imchipwood commented 2 years ago

Huh, thought I'd changed it to DEAF or something else silly.. Anyway thanks for contacting me first - I don't really care what the vendor ID is so long as the device ID still shows up as 'dumbpad' when plugged in!

Feel free to change it!

On Mon, Jan 24, 2022, 11:29 PM Matthias Liffers @.***> wrote:

Theoretically this is an issue to raise in the QMK repo, but I wanted to get your attention.

It looks like the VENDOR_ID for the Dumbpad is still the default of 0xFEED.

Would you be able to change the VENDOR_ID so that I can submit my VIA config to VIA? Alternatively, I would be happy to change the VENDOR_ID and submit a PR. Figure it would be polite to ask you first since you're the Dumbpad's creator!

— Reply to this email directly, view it on GitHub https://github.com/imchipwood/dumbpad/issues/15, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ456NHEGCCJ7QKT2A7RFTUXZGOPANCNFSM5MXOU2LA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

imchipwood commented 2 years ago

Looks like the qmk_firmware PR was reverted - are you planning on reworking that?

Anyway, I'm gonna close this - feel free to email me or contact me somewhere else if you want help with the VIA support, I've had a few folks ask if it's possible to add but haven't had the time to look into it.

mpfl commented 2 years ago

Looks like the qmk_firmware PR was reverted - are you planning on reworking that?

Sorry, I get distracted easily and have been working on other projects. I might pick it up again but given how unreliable I know I am, I'll put it on hold for now.

medoix commented 2 years ago

Just noting that my PR to merge in the OLED firmware also makes the VENDOR_ID change here https://github.com/qmk/qmk_firmware/pull/17058/files#diff-c34bacd1d7271500b70bcbec925dae2da916c0e295de920decee8f4e66a67d78R22

This will then unblock the one current reason for no VIA support in this PR https://github.com/the-via/keyboards/pull/1255