imchipwood / dumbpad

Simple 4x4 numpad with rotary encoder. Powered by QMK via ATmega32u4 Pro Micro
GNU General Public License v2.0
373 stars 57 forks source link

Contribute KEEBD Dumbpad OLED version #20

Closed medoix closed 2 years ago

medoix commented 2 years ago

It appears someones previous commit included this version from our fork into the README so i am raising a PR to commit the files up so the links work. I can also add the firmware via a PR is it helps.

The main changes in this combo_oled version is the replacement of the LED's and resistors for a single OLED display that can be programmed to show all of the relevant layer info plus more.

medoix commented 2 years ago

@deveth0 @imchipwood

deveth0 commented 2 years ago

Ouch, my fault 🗡️

Thanks for the finding and the contribution, could you probably add one or two images to the README?

medoix commented 2 years ago

No worries it reminded me to push this upstream. I have added a README with images.

deveth0 commented 2 years ago

love it <3

probably i'll need to make a dumbpad_oled_rgb next? :D

medoix commented 2 years ago

I had that exact same thought, maybe we can collab on that to make the worlds best dumbpad 😆

imchipwood commented 2 years ago

I love open source - thanks to both of you for contributing!

I'll review this some time this week, might even be time for me to learn kicad..

On Tue, Apr 26, 2022, 1:26 AM medoix @.***> wrote:

I had that exact same thought, maybe we can collab on that to make the worlds best dumbpad 😆

— Reply to this email directly, view it on GitHub https://github.com/imchipwood/dumbpad/pull/20#issuecomment-1109502985, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ456IFCMFMOX4WJWNPWDTVG6SCPANCNFSM5UHAV3EQ . You are receiving this because you were mentioned.Message ID: @.***>

imchipwood commented 2 years ago

image

Opened the schematic with kicad 6.x and was presented with an error about a missing drawing sheet - should this be included somewhere?

Other than that, I approve!

medoix commented 2 years ago

image

Opened the schematic with kicad 6.x and was presented with an error about a missing drawing sheet - should this be included somewhere?

Other than that, I approve!

Good catch, i believe i have fixed that issue now.