search

imchipwood / dumbpad

Simple 4x4 numpad with rotary encoder. Powered by QMK via ATmega32u4 Pro Micro
GNU General Public License v2.0
373 stars 57 forks source link

hi, i had an issue on the encoder and the third led #3

Closed ryandiwdjj closed 4 years ago

ryandiwdjj commented 4 years ago

the default mapping on qmk_firmware, the rotary and the third LED doesn't work (im using the v1.1 board) but i already make the fix and if you want i can send my files. (sorry for my bad english as it is not my mother language)

imchipwood commented 4 years ago

What branch did you use to build the qmk_firmware? The correct branch is dumbpad_refactor - maybe I forgot to push some code?

ryandiwdjj commented 4 years ago

i dont see any branch named dumbpad_refactor

imchipwood commented 4 years ago

OK, I see. You're talking about this repo and the Eagle files.

No update is needed in this repository if you use the correct qmk_firmware branch.

I am using a v1.1 right now and it's working fine with the code in imchipwood/qmk_firmware/tree/dumbpad_refactor

imchipwood commented 4 years ago

The reason for this: v1.1 is significantly different from v1.0, in order to support both single- and dual-encoder layouts. The v1.1 layout uses the same encoder & LED pins as v0.6_dualencoder - the v1.1 design is actually based around the original dualencoder designs.

ryandiwdjj commented 4 years ago

aahh i see, anyway i have already fix it by myself after i trace it one by one LOL, i just though maybe someone out there had the same issue as me, thanks for the reply though! the design sure is beautiful!

imchipwood commented 4 years ago

Glad you like it, do you mind sending me a photo of yours? I like seeing what people have made :)

ryandiwdjj commented 4 years ago

here's mine, i use the third LED as my third layer indicator lmao, also forgive me as i'm not using the pcb mount switch, so it looks like a little bit misalign.

https://imgur.com/1YVRIGx

imchipwood commented 4 years ago

Awesome, I hadn't seen anyone put the encoders in opposite corners like that yet!

Thanks for the photo - do you mind if I include it in the v1.1 README?

ryandiwdjj commented 4 years ago

yea i don't mind, hahahaha i think its kinda weird too but that is the most comfortable layout for me, also i'm going to try to make the acrylic case for it in free time, when its done i'm going to put the file in this issue

imchipwood commented 4 years ago

I'd actually like to close this issue - feel free to submit another issue when you've made the case!