Fix use of OMP - Githubissues

imcs-compsim / MIRCO

A shared-memory parallel BEM code for the contact of rough surfaces

MIT License

2 stars 3 forks source link

Fix use of OMP #24

Closed NoraHagmeyer closed 2 years ago

NoraHagmeyer commented 2 years ago

Bug Description: What's going wrong?

The compiler warns that it is ignoring the OMP prgmas. This problem was probably introduced in !7. At the very least the warning was introduced by !7.

Expectations

Possible Solution

Steps to Reproduce

Your Environment

Relevant repo SHA1s:
Relevant configure flags or configure script:
Operating system and version:
Compiler and TPL versions:

Related Issues and Merge Requests

Blocks
Follows !7
Related to
Part of
Composed of

Interested Parties

@RShaw026

NoraHagmeyer commented 2 years ago

@RShaw026 Could you please copy the warning you were talking about in paste in here?

NoraHagmeyer commented 2 years ago

In GitLab by @RShaw026 on Dec 16, 2021, 09:26

@NoraHagmeyer I am getting the following kind of errors for all the omp parallel directives:

/home/a11erish/Documents/bem_code/bem/src/evaluate.cpp:55: warning: ignoring #pragma omp parallel [-Wunknown-pragmas] 55 | #pragma omp parallel for schedule(static, 16)

I tried adding -fopenmp compiler flag and I could not see those warnings anymore.

NoraHagmeyer commented 2 years ago

@RShaw026 Feel free to start a MR for your fix then :thumbsup:

NoraHagmeyer commented 2 years ago

In GitLab by @RShaw026 on Dec 16, 2021, 11:10

mentioned in commit 70f7bb01473c8fa50af0a178e4af2e5214199904

NoraHagmeyer commented 2 years ago

mentioned in commit a6e32a860ef155637279418f9f2a9c54b54ff3eb