imcs-compsim / MIRCO

A shared-memory parallel BEM code for the contact of rough surfaces
MIT License
2 stars 2 forks source link

Add documentation #53

Closed RShaw026 closed 2 years ago

RShaw026 commented 2 years ago

Description and Context

Documentation has been added to the code explaining the functions and the variables.

Related Issues and Pull Requests

How Has This Been Tested?

Building and running ctest

Checklist

Additional Information

Please let me know of any possibility of renaming variables using more descriptive names.

Interested Parties / Possible Reviewers

@NoraHagmeyer

NoraHagmeyer commented 2 years ago

I think documentation will really help with understanding and maintaining the code in the future.. this is a good start. 2 general remarks: I'd put the documentation of functions above the function header and not into the function body. Secondly, in other codes we usually put the function documentation in the header file. The main reason is the use of doxygen, which we do not use here. But, to be consistent, and in case doxygen is used at some point, I'd suggest to do the same here.

NoraHagmeyer commented 2 years ago

Make sure to resolve the conflicts, i.e. by rebasing on the updated master.

NoraHagmeyer commented 2 years ago

Definitely makes the code easier to read. All remarks are just suggestions, mainly to be consistent with other codes such as BACI. But, in general, every comment makes the code better.

NoraHagmeyer commented 2 years ago

@RShaw026 What's the status of this pull request?

RShaw026 commented 2 years ago

@NoraHagmeyer last week I was working on working on changing how MIRCO would be called from BACI. That may require changing some files. Therefore, I thought of adding this merge request after those changes are made.