Closed RShaw026 closed 1 year ago
I had a look and I'm fine with the changes, but first I would really like to have a second opinion of someone who has a better understanding of CMake and how things work together.
To avoid printing the Trilinos configuration messages while building BACI, I have moved them inside the TRILINOS_IN_MIRCO
flag. These things will help us to integrate MIRCO into BACI; however, the CMakeLists in MIRCO need to be redesigned.
Let's with this PR until PR #78 has been merged.
Description and Context
When used as an external library in BACI, some linker issues occurred because of the use of a static library. Therefore,
mirco_library
target is converted to dynamic library and OpenMP dependency in added to it. The ideal case would be to makemirco
as a dynamic library, but I was facing some issues regarding that. So I will open an issue regarding it. Merging this PR is required to move ahead with our BACI/MIRCO integration. Also,-Werror
compiler flag is added to treat warnings as errors in the pipeline.Related Issues and Pull Requests
How Has This Been Tested?
ctest
is working.mirco
executable is working.mirco_library
is used in BACI in my local, and it is working.Checklist
Additional Information
Interested Parties / Possible Reviewers
@mayrmt