imcs-compsim / MIRCO

A shared-memory parallel BEM code for the contact of rough surfaces
MIT License
2 stars 3 forks source link

Do not search for MPI with warnings enabled #89

Closed sebproell closed 9 months ago

sebproell commented 10 months ago

Description and Context

When finding MPI with -Wextra on, a warning is reported in some deprecated CXX bindings. Avoid this by moving the modification of CMAKE_CXX_FLAGS behind the find_package() call. This avoids issues when users set -Werror in their CMAKE_CXX_FLAGS variable.

How Has This Been Tested?

Local build.

Checklist

Additional Information

Interested Parties / Possible Reviewers

FYI @amgebauer

isteinbrecher commented 9 months ago

Pipeline passed, I am not that familiar with the cmake setup of MIRCO, but I think this looks good to me. @RShaw026 , @mayrmt any objections?

sebproell commented 9 months ago

have you seen problems in your local build?

@mayrmt No.

RShaw026 commented 9 months ago

@isteinbrecher I do not have any objections. It looks good to me.