Closed sebproell closed 9 months ago
Pipeline passed, I am not that familiar with the cmake setup of MIRCO, but I think this looks good to me. @RShaw026 , @mayrmt any objections?
have you seen problems in your local build?
@mayrmt No.
@isteinbrecher I do not have any objections. It looks good to me.
Description and Context
When finding MPI with
-Wextra
on, a warning is reported in some deprecated CXX bindings. Avoid this by moving the modification ofCMAKE_CXX_FLAGS
behind the find_package() call. This avoids issues when users set-Werror
in theirCMAKE_CXX_FLAGS
variable.How Has This Been Tested?
Local build.
Checklist
Additional Information
Interested Parties / Possible Reviewers
FYI @amgebauer