search

imcs-compsim / MIRCO

A shared-memory parallel BEM code for the contact of rough surfaces
MIT License
3 stars 3 forks source link

Fix two warnings when compiling with Clang #92

Closed sebproell closed 8 months ago

sebproell commented 8 months ago

While experimenting with the build system in BACI, I found two warnings when compiling MIRCO with Clang. While there is, of course, no need to adapt to warning flags of an upstream project (they should keep them only to themselves) I believe we might as well fix them here. One warning points to an unused variable, the other one to a missing virtual destructor.

mayrmt commented 8 months ago

@sebproell, thanks for proposing these changes!

@RShaw026, I'd be in favor of adapting MIRCO's warning flags to protect against such issues. Doing so will not negatively impact code development in MIRCO, but might help us to keep the code clean. Please look into it!

RShaw026 commented 8 months ago

@mayrmt Okay, I will look into it. @sebproell Thanks for the changes. They look good to me.