imcs-compsim / MIRCO

A shared-memory parallel BEM code for the contact of rough surfaces
MIT License
3 stars 3 forks source link

Remove hard-coded test directory #42 #93

Closed RShaw026 closed 4 months ago

RShaw026 commented 4 months ago

Description and Context

The hard-coded TEST_DIRECTORY has been removed from the GitHub workflow. It is replaced with $(pwd). The run command is also adjusted accordingly.

Update: I have removed the use of $(pwd) now and using ${{github.workspace}} now, as suggested by @eulovi

Related Issues and Pull Requests

How Has This Been Tested?

The workflow runs without issues in this branch.

Checklist

Additional Information

Interested Parties / Possible Reviewers

@mayrmt @eulovi

RShaw026 commented 4 months ago

In #42 Nora had mentioned that trying $(pwd) did not work. I am not sure what she meant, but it works fine with the way I did it now. If this is not the way I am supposed to do it, then the other option would be to do the following run: echo "TEST_DIRECTORY=$(pwd)" >> $GITHUB_ENV

eulovi commented 4 months ago

I think the current option with github.workspace is even better since it takes directly the working directory used by the GitHub runner as pointed out in the documentation. Therefore, I think this can be merged.