search

imcs-compsim / meshpy

A general purpose 3D beam finite element input generator
Other
9 stars 3 forks source link

Fix mesh creation for helical geometries #73

Closed davidrudlstorfer closed 3 months ago

davidrudlstorfer commented 3 months ago

See #72

Add a temporary mesh to the helical mesh creation function to simplify the mesh creation procedure

isteinbrecher commented 3 months ago

Looks good to me. Can you also add this to the testing? Should be sufficient if you simply add a line to the mesh in all the test cases before create_helix function is called.

davidrudlstorfer commented 3 months ago

Thanks for your review, I've added a simple line geometry to the four corresponding helix test cases. I've also checked the resulting reference files and .vtk output to verify the correctness.