search

imcs-compsim / meshpy

A general purpose 3D beam finite element input generator
Other
13 stars 3 forks source link

Improve helix mesh creation parameters #92

Closed isteinbrecher closed 3 months ago

isteinbrecher commented 3 months ago

A the moment the helix mesh creation function always takes the twist_angle and then requires either the height or the number of turns. In general two of these three parameters are needed to fully define the wanted helix (wile some corner cases might require a specific combination). The API to the function should represent this to ease the user the creation of a helix in whichever variant is best suited for the problem at hand.

In this discussion the "missing" parameter conversion is explained: https://github.com/imcs-compsim/meshpy/issues/87#issuecomment-2242452732

isteinbrecher commented 3 months ago

@davidrudlstorfer @knarfnitram I took the liberty of assigning you, maybe one of you can have a look into this in the future. Feel free to unassign.

davidrudlstorfer commented 3 months ago

Sorry if the thumbs up at the last issue wasn't self explanatory - I'm already at it and will create a PR soon.