HTML Validation Errors

[neilmispelaar]

Hi @naomileron

Absolutely awesome submission for Assignment 02 🎉! Your code is beautiful.

Issue Description

I ran your code through the HTML Validator and there are a couple of errors caused by using spaces " " in your file names for the images.

If you would like to take some additional time to address these small items, or make any further tweaks to your page, you may make changes to your code for the the next 72 hours without penalty.

Please note, no issues were found in when I ran your CSS through the validator! Great job there.

HTML Validator Results

Here is the link to the full results:

https://validator.w3.org/nu/?doc=https%3A%2F%2Fimd1005-web-development-winter-2023.github.io%2Fassignment-02-naomileron%2F

Screenshot

[naomileron]

Thank you so much! I'll definitely fix these things. I just had one question. One of the errors in this list is placing button tags inside "a" tags. I noticed that too while I was working on the assignment, but when I tried to get rid of the a tags, it changed the alignment of some of the buttons. What could I do to fix that?

[neilmispelaar]

Ideally if the “button” is linking a user to another page on your site you should use an a anchor element instead of a button.

If however the “button” is controlling a user interaction like a button on a form, or a button on an app, you should use the button element.

Depending on what these buttons are doing for the user, first determine if you are using an a or a button and then I would recommend using CSS flex or grid styles to style them all.

If you can share a screenshot of the alignment problems you have I can try to make some smarter recommendations.

Thanks.

[naomileron]

Okay, this makes a lot more sense, thank you for the clarification. Before I change anything, I wanted to ask: My buttons were supposed to be linking to other pages. Since the site isn't functional, would it be okay if I just left them as buttons, or should I change my code entirely to have them as a tags?

Thank you!

[neilmispelaar]

For the purpose of this assignment you can absolutely leave them as button elements!

For future projects, before you use a a or a button just consider what they might be linking to / what use action is being taken.

[naomileron]

Okay thank you! I also figured out why my button alignment got changed when I deleted the "a" tag - it was because it was deleting the div too so that changed its position. Thank you so much for all your help!