imd1005-web-development-winter-2023 / assignment-03-oliviascout

assignment-03-oliviascout created by GitHub Classroom
https://imd1005-web-development-winter-2023.github.io/assignment-03-oliviascout/
MIT License
0 stars 0 forks source link

Team Member Code Review #3

Open RoboRaccoon opened 1 year ago

RoboRaccoon commented 1 year ago

Code Review

Results summary

I liked the idea of putting the completed tasks in a separate list (I actually used your idea for my app, hope you don't mind). The colour differentiation between the completed and incomplete todos was a nice touch.

The app needs to be responsive, which is something that your app doesn't have at the moment because things are getting cut off when todos are added to the list.

I like the idea of being able to delete all the todos at once is convenient, but I think being able to delete individual todos is what was intended. Although, you can take this either way from how Neil wrote this requirement since he just said the app should "enable users to view, add, mark as done, and delete todos", so I guess you can take this as deleting all at once or individually.

Checklist

In the app, I am able to add todos, mark them as done, and delete them

image

Apparently you need an "awesome" empty state, form the empty sate that I currently see, I think you can make this design look more "awesome". I think most people added a background image, here was the example link that was provided in the assignment: https://www.toptal.com/designers/ux/empty-state-ux-design

image

The app also needs to be responsive and from testing, the "To-Do list app!" and input box text gets cut off at the front.

Yes, the github page is active in the repo and the web app is live

No errors found in index.html: passes W3C HTML validation!

No errors found in style.css: passes W3C CSS validation!

Screenshot

Add a screenshot of the app that you were testing.

This is what the app looks like for me when it's first opened: image

Trying to delete individual tasks: image

Testing responsiveness: image image