search

imdrasil / jennifer_sqlite3_adapter

SQLite3 adapter for Jennifer ORM
MIT License
13 stars 7 forks source link

Moving the SQLite adapter into the jennifer codebase #39

Closed SebastianSzturo closed 2 years ago

SebastianSzturo commented 2 years ago

Would it be possible to merge the SQLite3 adapter into the main codebase or is there a good reason to keep it outside?

imdrasil commented 2 years ago

Initially my idea was to separate adapters from the Jennifer so the codebase be less coupled together and be more independent. At the very beginning I decided to couple them together temporary to simplify the work. SQLite was the 1st adapter I've decided to separate from the ORM library. I believe I just need to change my habit - I used to update SQLite code base after Jennifer release (what happens far not so often I'd like) and update it right after I merge something into Jennifer master branch

SebastianSzturo commented 2 years ago

Ah makes sense, thanks for the explanation! Makes sense 👍🏻

SebastianSzturo commented 2 years ago

Thinking about it a bit more, it would probably be a good idea to have all officially supported adapters in the same repo like ActiveRecord does it to share the same CI/specs to find issues faster.

Obviously it's up to you!

imdrasil commented 2 years ago

may be a good idea - will take a look how this can be implemented taking into account shards utility mechanism of work