Decorator, constructor variables

imekachi / webstorm-darcula

A VSCode theme trying to be as close as possible to IntelliJ WebStorm Darcula theme and includes some improvements

https://marketplace.visualstudio.com/items?itemName=imekachi.webstorm-darcula

10 stars 4 forks source link

Decorator, constructor variables #3

Open draylegend opened 3 years ago

draylegend commented 3 years ago

Just wanted to thank you for the theme!!! Awesome similarity!!!

Left VSCode, right WebStorm

Maybe you could adjust the decorator and constructor variable colors?

imekachi commented 3 years ago

Thank you for your appreciation :)

I've tried writing decorator in js, ts file this is what I got

Maybe it's related to an Angular plugin. Which one are you using? send me a link I'll try to install that.

And I don't have an angular project, it would be nice if you can give me an example repo to debug.

draylegend commented 3 years ago

Extensions installed in VSCode:

imekachi commented 3 years ago

@vladimirdrayling Man, I'm out of idea here. VSCode thinks it's a class and overrides the decorator highlighting with class highlighting.

You can try to turn the semantic highlighting off by setting this to false and see which one works best for you.

BTW, Turning semantic highlighting off will lead to other highlighting issues, for example, VScode cannot differentiate the decorator itself and function calls inside and assumes they are "decorators" because there is meta.decorator in the scope.

Let me know if you or anyone has some idea to fix this. PRs are welcome.

draylegend commented 3 years ago

@imekachi thank you for detaild answer!! This is not a problem at all))

I thought it would be easy to fix LOL

For now I'm totally fine with that theme. And again, this is by far the best VSCod theme . ChrisPrattWowGIF

If you want, you can close this issue, coz functionality is currect))