imengyu / Ballance

经典游戏平衡球的 Ballance Unity 复刻版
https://imengyu.github.io/Ballance/#/readme
GNU General Public License v3.0
205 stars 24 forks source link

[Spell] Rename bouns -> bonus text on LevelScore #25

Closed MrPenguin07 closed 9 months ago

MrPenguin07 commented 9 months ago

Hi,

I'm uncertain if "Bouns" is intentional or not, however believe this is a simple typo? There are various references to "bouns" in the code;

./Assets/Game/Menu/Prefabs/Pages/PageEndScore.prefab
155:  ScoreBouns: {fileID: 363385645329760179}
357:  m_ResourceKey: core.ui.WinUILevelBouns
1176:  m_Name: ScoreBouns

./Assets/Game/PackageLanguageRes.xml
19:    <Text name="core.ui.WinUILevelBouns">关卡分数</Text>
233:    <Text name="core.ui.WinUILevelBouns">Level Bouns</Text>
431:    <Text name="core.ui.WinUILevelBouns">關卡分數</Text>

./Assets/Game/Menu/Scripts/Game/WinScoreUIControl.cs
15:    public Text ScoreBouns;
129:      ScoreBouns.text = _GamePlayManager.LevelScore.ToString();
213:      ScoreBouns.text = _GamePlayManager.LevelScore.ToString();
247:      ScoreBouns.text = "0";

However this PR does not try to change the spelling of your functions as that may have unintended consequences. I believe this PR simply fixes the text for the levelscore presented to the player at the end of each level.

Regards

aaasoft commented 9 months ago

Thanks for your contrbute.

MrPenguin07 commented 9 months ago

Thanks for your contrbute.

Thanks for the game :)