imerfanahmed / dash-soketi

A beutifull Dashboard For Soketi
2 stars 2 forks source link

Some feedback #1

Open vesper8 opened 8 months ago

vesper8 commented 8 months ago

Hey hey! I just migrated from using laravel-websockets to Soketi and of course one of the first things I did was search for some kind of dashboard because I missed the dashboard that laravel-websockets offered. So I was very happy to find a newly released project that adds a nice dashboard built with Laravel. So big kudos for making this and thank you!

I just finished setting it up to run on my localhost on my Mac and I have a few comments for small issues that I ran into. I'm hoping you can maybe implement those changes in an upcoming update : )

I'm going to include small nitpicks too, I hope you don't mind.

1- Your .env.example has APP_ENV set to production, I feel like it should be set to local like the default .env.example 2- In my case I ran into errors when Soketi tried to connect to the mysql database. It didn't correct parse the SOKETI_DB_MYSQL_HOST={$DB_HOST} and all other lines that make use of {$DB_XXX}. In order to get it to work, I had to fill those lines up with the actual values 3- For me Soketi was unable to connect to Mysql when the DB_HOST was set to localhost, when I changed it to 127.0.0.1 then it worked 4- I imported a list of existing apps which I added to the DatabaseSeeder. In my case I already had my own ids and those were already configured in many different projects, so I added 'id' to the fillables in the App.php model, I think this would be a sensible default 5- Since I'm using a self-signed certificate on my localhost (generated by Laravel Valet), I had to change $client = new Client(); to $client = new Client(['verify' => false]); inside the Navigation.php file otherwise it would always show that Soketi Status was offline. I think this is also a sensible default to add when env is local. Maybe you could add "guzzle_options" to the config file so we can set it there. 6- I noticed that you cannot edit any of the app settings from the Dashboard. Nor can you set the webhooks. Would be nice to be able to customize those parameters, view them and edit them. Also I don't know if following an update if Soketi would need to be restarted in order for it to use the latest changes? How does it work right now, is an app immediately available after you add it? 7- The debug tab doesn't seem to display anything, it would be really nice if it displayed the live events for that app similar to what the laravel-websockets used to display. Any plans to add these metrics in? I see the events in the CLI since I enabled debug mode, it would be nice to see all those events on the dashboard and maybe have a line chart as well.

That's it for now. Looking forward to future updates! Thanks a lot!

imerfanahmed commented 8 months ago

wonderful, I never imagined this way, I created this for my hobby project since I am in full-time job, its very hard to get time for hobby projects, so this was the reason that most of the featured didn't work as it should, anyways, I would humbly request you to send some PR to improve this project, so we can make a great product instead! what do you say? and last but not least take love from my core of heart!