imfing / pile

:zap: A simple & powerful app to organize your piled work at one place~
GNU General Public License v3.0
166 stars 15 forks source link

Themes #22

Closed gzimmers closed 6 years ago

gzimmers commented 6 years ago

Never worked with vue or electron, so still getting a feel for things. But I figured adding themes would be pretty easy. It's almost done. Let me know if you're interested in using this. Otherwise I'll just trash it.

Though if you are interested, I'll resolve the conflicts and finish it up. If that is the case, I have a question or two for you.

imfing commented 6 years ago

Thank you very much. 👍 You can still work on this. A theme system would be great! #16

There are several problems need to be taken care:

Thank you. I'm waiting for your modification and PRs. This would be great.

gzimmers commented 6 years ago

Sweet, I'll spend some time finishing it up.

The theme system should be hackable, which means users can further customize the details like color, font, or other appearance in a file like style.css.

Totally agree, though I couldn't think of a way to generate a dynamic style.css. If you could point me in the right direction regarding generating a css file dynamically without hacking it to bits, that would be great. But otherwise, I'll continue with my approach of using style objects and v-bind to attach them.

My other question was regarding the TabsPane. I'm having difficulty styling it and I can't seem to figure out where you got the component. If you could refer me to the docs that provided that component so I could read about how to style it, that would be great.

imfing commented 6 years ago

The UI kit for this app is iview Check its components. I'll look into this theme-building tool or anything similar, I think it will help speed up the procedure of customizing a theme for the contributors.

Besides that, the way I thought is to create a blank style.css in the user directory to override the default settings. But I haven't come up with a perfect solution 'cause you have to write them line by line, it's too wearisome.

If you need my help, I could open a new branch named theme for your pull request so that I could review and fix something. Thanks for spending time on this app. If you'd like, we can communicate in private using email or other Instant Message tools. 😄

gzimmers commented 6 years ago

Agreed, I emailed you. We can schedule something there.

imfing commented 6 years ago

Ok, I'm gonna close this PR. Check email 😄