imgflo / imgflo-server

HTTP image processing server based on imgflo
48 stars 7 forks source link

Deploy to Heroku using deploy button fails #4

Closed automata closed 9 years ago

automata commented 9 years ago

Clicking on Deploy to Heroku link failed with this error.

jonnor commented 9 years ago

Possibly this http://stackoverflow.com/questions/13362288/heroku-push-rejected-submodule-install-failed Testing

jonnor commented 9 years ago

No, looks like a Heroku Button problem. It is not fetching the git submodules no matter what. Support issue created: https://help.heroku.com/tickets/203823

@automata creating the app in Heroku dashboard and deploying using git push should work just fine

automata commented 9 years ago

Deployed with success. (The commands differ a little bit from those of README, should I PR?)

However, the app crashes. Reading the logs I guess it's possibly because we should specify an alternative to AWS, right?

jonnor commented 9 years ago

Sure, documentation update welcomed. Use envvar IMGFLO_CACHE=local

automata commented 9 years ago

PR'ed. Running smooth: http://automata-imgflo.herokuapp.com/

jonnor commented 9 years ago

Support says git submodules not supported with deploy button right now. I tried to make a workaround with custom buildpack, but it fails because even the .gitmodule file is not included. Would have to duplicate the configuration, which I'm really not very keen on...

jonnor commented 9 years ago

Fixed with a bit ugly fix. Also made the local cache the default instead of s3. One minor problem remains though: #6