search

imgflo / imgflo-server

HTTP image processing server based on imgflo
48 stars 7 forks source link

Add preprocess graph (rotate and crop) #44

Closed automata closed 8 years ago

automata commented 8 years ago

Need gegl:rotate-on-center support.

jonnor commented 8 years ago

@automata that is not a very good name, too generic, says nothing about what it does. Would prefer something like rotateandcrop or croprotate. The GEGL op has been committed, in progress of updating imgflo-dependencies now

automata commented 8 years ago

@jonnor I was calling it preprocess thinking about its role, and it would make its semantics valid even if we change its internals in the future (e.g. adding a sharpening filter?). But I agree, that's not informative enough, I can rename it.

jonnor commented 8 years ago

That role only makes sense in the particular usecase we have for it (which is outside imgflo-server).

automata commented 8 years ago

:+1:

jonnor commented 8 years ago

@automata Can you rebase/merge this with master? The GEGL operation should be in now.

jonnor commented 8 years ago

Rebased and pushed to master

jonnor commented 8 years ago

With one fix, https://github.com/jonnor/imgflo-server/commit/722b3f166b27428cbb490dc67c8a0d12566e147d