imgflo / imgflo-server

HTTP image processing server based on imgflo
48 stars 7 forks source link

BABL performance regression #59

Open jonnor opened 8 years ago

jonnor commented 8 years ago

Old

babl edc3ea3ba8509bc49368e8dd6dfd62c2619cc30e
gegl c842f4e304bc70198ea03f3803dd28aba262607

16 concurrent: [3591, 3479]
3200px:  [3963, 3774]

Current

babl d58336b72657f54952b77a13a541a7b86079931d
gegl 7ce5f3b902c0399ff4b62d2a84c57ab1ae03bc5

16 concurrent: [4912, 4481]
3200 px: [4812, 4585]

With new babl, old GEGL

babl d58336b72657f54952b77a13a541a7b86079931d
gegl c842f4e304bc70198ea03f3803dd28aba262607c

16 concurrent: [4597, 4570]
3200px: [4580, 4603]
jonnor commented 8 years ago

Going to try with only new babl, keeping gegl at old version: https://github.com/jonnor/imgflo-dependencies/commit/32c624d7bfa5f20bdfac446750d0d816d97122f3

jonnor commented 8 years ago

Seems babl changes are the main problem. Will need to bisect them locally.

jonnor commented 8 years ago

Seems to be due to the changes in table-based lookups in BABL. They were just intended to be moved to own extension, but seems something is missing/broken now. https://github.com/GNOME/babl/commit/164e1327aa5d1d2e855a6472c38a0ba929fed1e1 https://github.com/GNOME/babl/commit/4f5d1b54bd4c57eb2b0471927ec74f911152e293