imgflo / imgflo-server

HTTP image processing server based on imgflo
48 stars 7 forks source link

Avoid needing HOSTNAME envvar #6

Open jonnor opened 9 years ago

jonnor commented 9 years ago

The local cache relies on HOSTNAME envvar to work correctly. This should be avoided to simplify config, perhaps by using an existing envvar set by Heroku or by headers/info on the incoming requests.

jonnor commented 9 years ago

Does not seem that Heroku sets an appropriate envvar. But incoming requests should in most cases the right value (and for the cases which is does not, use manual override)

jonnor commented 9 years ago

We do this in imgflo (runtime): https://github.com/jonnor/imgflo/commit/f92446b9efa349c64a356a52ad4c5773070751c8