search

imgix / ember-cli-imgix

Easily add imgix functionality to your Ember application
https://imgix.github.io/ember-cli-imgix
MIT License
26 stars 13 forks source link

chore(test): add Embroider for ember compatibility testing #211

Closed rahulk94 closed 2 years ago

rahulk94 commented 2 years ago

Description

This PR adds Embroider to the Ember Try compatibility scenarios as per https://github.com/embroider-build/embroider/tree/master/packages/test-setup. At the same time, I've also snuck in a git ignore change to avoid tracking yarn lock file generated when running tests with Ember Try.

Relates to issue https://github.com/imgix/ember-cli-imgix/issues/210.

Checklist

I've omitted the checklists as none seem relevant.

Steps to Test

yarn test

Fwiw at this stage the project does not support Embroider (see https://github.com/imgix/ember-cli-imgix/issues/210) so the new Embroider test scenarios are failing (along with Ember 4 as thats the latest beta these days, but thats the same issue on master).

=== Scenario: embroider-safe ===================================================

WARNING: Node v12.22.6 is not tested against Ember CLI on your platform. We recommend that you use the most-recent "Active LTS" version of Node.js. See https://git.io/v7S5n for details.
Could not start watchman
Visit https://ember-cli.com/user-guide/#watchman for more info.
⠋ BuildingSuccessfully applied EMBROIDER_TEST_SETUP_OPTIONS=safe
Building into /private/var/folders/_b/525y2kfj6sg6l_gbcnf29qsm0000gp/T/embroider/bb304d
this.app.getLintTests is not a function

Stack Trace and Error Report: /var/folders/_b/525y2kfj6sg6l_gbcnf29qsm0000gp/T/error.dump.31dc14f166c3e744856c7a7100b397e1.log
Result: false
---

WARNING: Node v12.22.6 is not tested against Ember CLI on your platform. We recommend that you use the most-recent "Active LTS" version of Node.js. See https://git.io/v7S5n for details.
Could not start watchman
Visit https://ember-cli.com/user-guide/#watchman for more info.
⠋ BuildingSuccessfully applied EMBROIDER_TEST_SETUP_OPTIONS=optimized
Building into /private/var/folders/_b/525y2kfj6sg6l_gbcnf29qsm0000gp/T/embroider/bb304d
this.app.getLintTests is not a function

Stack Trace and Error Report: /var/folders/_b/525y2kfj6sg6l_gbcnf29qsm0000gp/T/error.dump.c6444d6319e3490b340c3200a442e7b5.log

Result: false
---

------ RESULTS ------
...
Command run: ember test
Scenario embroider-safe: FAIL
Command run: ember test
with env: {
  "EMBROIDER_TEST_SETUP_OPTIONS": "safe"
}
┌────────────────────┬────────────────────┬──────────────────────────────┬──────────┐
│ Dependency         │ Expected           │ Used                         │ Type     │
├────────────────────┼────────────────────┼──────────────────────────────┼──────────┤
│ @embroider/core    │ 0.47.1             │ 0.47.1                       │ yarn     │
├────────────────────┼────────────────────┼──────────────────────────────┼──────────┤
│ @embroider/webpack │ 0.47.1             │ 0.47.1                       │ yarn     │
├────────────────────┼────────────────────┼──────────────────────────────┼──────────┤
│ @embroider/compat  │ 0.47.1             │ 0.47.1                       │ yarn     │
├────────────────────┼────────────────────┼──────────────────────────────┼──────────┤
│ webpack            │ ^5.0.0             │ 5.60.0                       │ yarn     │
└────────────────────┴────────────────────┴──────────────────────────────┴──────────┘

Scenario embroider-optimized: FAIL
Command run: ember test
with env: {
  "EMBROIDER_TEST_SETUP_OPTIONS": "optimized"
}
┌────────────────────┬────────────────────┬──────────────────────────────┬──────────┐
│ Dependency         │ Expected           │ Used                         │ Type     │
├────────────────────┼────────────────────┼──────────────────────────────┼──────────┤
│ @embroider/core    │ 0.47.1             │ 0.47.1                       │ yarn     │
├────────────────────┼────────────────────┼──────────────────────────────┼──────────┤
│ @embroider/webpack │ 0.47.1             │ 0.47.1                       │ yarn     │
├────────────────────┼────────────────────┼──────────────────────────────┼──────────┤
│ @embroider/compat  │ 0.47.1             │ 0.47.1                       │ yarn     │
├────────────────────┼────────────────────┼──────────────────────────────┼──────────┤
│ webpack            │ ^5.0.0             │ 5.60.0                       │ yarn     │
└────────────────────┴────────────────────┴──────────────────────────────┴──────────┘

3 scenarios failed
3 scenarios succeeded
commit-lint[bot] commented 2 years ago

Contributors

rahulk94

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
rahulk94 commented 2 years ago

Closing for the moment as we need to get to Ember 3.16 before this is valid.