search

imgix / ember-cli-imgix

Easily add imgix functionality to your Ember application
https://imgix.github.io/ember-cli-imgix
MIT License
26 stars 13 forks source link

chore(release): 3.0.0 #214

Closed frederickfogerty closed 2 years ago

frederickfogerty commented 2 years ago

This PR is a draft release for v3.0.0. I'm opening this as a PR so there is an opportunity for feedback for the release notes from @rahulk94

commit-lint[bot] commented 2 years ago

Chore

Contributors

frederickfogerty

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
rahulk94 commented 2 years ago

Question @frederickfogerty do you want to change this repo to use @imgix/js-core during this release? Would it be considered a breaking change that must go in a major (I think yes because its a dependency change but could be wrong)?

I was about to try doing it but the build stuff in index.js has confused me so not sure what I'm meant to do there 😂 I've opened https://github.com/imgix/ember-cli-imgix/pull/215 if you wanna try it.

Fwiw I'm fine to leave this out but thought I would call it out just incase.

rahulk94 commented 2 years ago

Also raised https://github.com/imgix/ember-cli-imgix/pull/216 as I missed updating docs earlier

frederickfogerty commented 2 years ago

Question @frederickfogerty do you want to change this repo to use @imgix/js-core during this release?

Yeah, I think this is a great idea. Technically it wouldn't have to be a breaking change since the APIs are the same, but I think it's good to get it in with this update. I'm working off your PR to try get something working 👍

frederickfogerty commented 2 years ago

@rahulk94 so I've merged the @imgix/js-core update in, thanks for doing most of the work on that. Do you think you could just briefly pull this project down and check everything works in one of your local projects? All the tests pass but I just want to check in a real project. After that we should be good to go!

rahulk94 commented 2 years ago

Hey @frederickfogerty I've done a quick test and current master (2d5899ceefe4da98ab1e2f3d4622c3b5a0d7316e) looks good for normal Embroider builds but is throwing some errors when run in Fastboot (serverside render). I'll poke around a bit more about this on Tuesday and let you know to make sure this isn't an issue with this library itself (potentially we need to tweak that index.js fastboot transform config further)

rahulk94 commented 2 years ago

Also we should loosen our @embroider/macros dependency to >=^0.47.2 so that consumers can better manage embrdoider dependencies https://github.com/imgix/ember-cli-imgix/pull/219

frederickfogerty commented 2 years ago

Alright @rahulk94 I look forward to your updates about Fastboot. Let me know if I can help out in any way

rahulk94 commented 2 years ago

@frederickfogerty sorry dude, hectic week. Haven't had a chance to test this yet. Will update you once I've had a chance to try it 🤞🏾 (will see if i can get a reproduceable test env otherwise if I'm slow)

rahulk94 commented 2 years ago

@frederickfogerty I managed to suss things on my end and tested against our app with embroider dependencies from version 0.48.1. This version is latest and is needed to make sure ember-get-config works correctly.

    // Flags for Embroider optimizations
    staticAddonTestSupportTrees: true,
    staticAddonTrees: true,
    staticHelpers: true,
    staticModifiers: true,

We've got other issues atm which prevent us from staticComponents and staticRoutes.

I reckon we're good to ship this and can address any other issues in any subsequent service packs.

rahulk94 commented 2 years ago

One last thing actually, I've tried running the embroiderSafe and embroiderOptimized options in the ember try config and both options are passing. I reckon we add this in before releasing too since its just internals/testing config now? Raised https://github.com/imgix/ember-cli-imgix/pull/220

frederickfogerty commented 2 years ago

I'm going to merge this in now, and let's get that embroider build change in later if we can get it to work

frederickfogerty commented 2 years ago

Released on npm. From all of us at the SDK team at imgix, a big thanks for all the work you've put in here @rahulk94 🙌