search

imgix / ember-cli-imgix

Easily add imgix functionality to your Ember application
https://imgix.github.io/ember-cli-imgix
MIT License
26 stars 13 forks source link

chore: enable embroider ember try configuration options #220

Closed rahulk94 closed 2 years ago

rahulk94 commented 2 years ago

Description

Enable embroider safe and optimized options in ember try config. This is now passing since Embroider 0.48.1 works with ember-cli-imgix.

commit-lint[bot] commented 2 years ago

Contributors

rahulk94

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
frederickfogerty commented 2 years ago

Unfortunately although the embroider builds are working, the other builds are failing (see screenshot). I've enabled forked CI builds, so you should be able to see build results for any commits you push.

image

rahulk94 commented 2 years ago

What the, how weird. Yeah I didn't run the whole suite locally since I didn't think the different runs should affect each other... Will take a look into this sometime.

frederickfogerty commented 2 years ago

@rahulk94 how are you feeling about this? It's totally fine to drop this if you don't have time - please close the PR in that case. Otherwise I look forward to any progress you make here

rahulk94 commented 2 years ago

Hey @frederickfogerty yeah I think we can park this and revisit it another time. I'll close the PR since I don't imagine I'll spend time on it over the next couple weeks 😂 .

I tried comparing the ember-cli-build config to https://github.com/sandydoo/ember-google-maps/blob/main/ember-cli-build.js which has embroider scenarios enabled and didn't see any hints on what we're doing differently.