imgix / ember-cli-imgix

Easily add imgix functionality to your Ember application
https://imgix.github.io/ember-cli-imgix
MIT License
26 stars 13 forks source link

fix: update htmlSafe import to @ember/template rather than @ember/string #223

Closed rahulk94 closed 2 years ago

rahulk94 commented 2 years ago

Description

Update htmlSafe import to @ember/template as the current usage is invalid when using Ember@3.27+. This fixes the following warnings when using these Ember versions (note that ember@3.28 is an LTS so its likely to be the version people use for a while yet).

WARNING in ./node_modules/ember-cli-imgix/components/imgix-bg.js 111:11-19
export 'htmlSafe' (imported as 'htmlSafe') was not found in '@ember/string' (possible exports: camelize, capitalize, classify, dasherize, decamelize, getString, getStrings, loc, setStrings, underscore, w)
 @ ./components/imgix-bg.js 1:0-78 1:0-78
 @ ./assets/my-app 864:9-45

Bug Fix

Steps to test

This has only been tested using unit tests. It probably is worth testing this against a real world ember app prior to merging (or we send it as its unlikely this will break things).

commit-lint[bot] commented 2 years ago

Contributors

rahulk94

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR