imgix / ember-cli-imgix

Easily add imgix functionality to your Ember application
https://imgix.github.io/ember-cli-imgix
MIT License
26 stars 13 forks source link

chore(deprecations): import `reads` from '@ember/object/computed' #227

Closed gilest closed 2 years ago

gilest commented 2 years ago

Description

Resolves deprecation id: deprecated-run-loop-and-computed-dot-access

Bug Fix

Steps to Test

Just a deprecation change. 😅 this is an intense PR template...

commit-lint[bot] commented 2 years ago

Chore

Contributors

gilest

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
gilest commented 2 years ago

@sherwinski @frederickfogerty could we take a look at this please?

This deprecated usage is a blocker for addon consumers wanting to upgrade to Ember v4.

gilest commented 2 years ago

Thanks @sherwinski . Would appreciate a minor release with this patch included 🙇🏻

sherwinski commented 2 years ago

@gilest Ah sorry about that, I was expecting semantic release to publish one automatically. I'll get this released for you today.

gilest commented 2 years ago

Would still be grateful for a release if that's possible 🙃

sherwinski commented 2 years ago

Here you go @gilest - just published v3.0.3 🎉 Thanks for your patience on this!