fix: set domain as optional - Githubissues

imgix / gatsby

A simple yet powerful integration between Gatsby and imgix

BSD 2-Clause "Simplified" License

30 stars 6 forks source link

fix: set domain as optional #263

Closed luqven closed 1 year ago

luqven commented 1 year ago

Description

Fix regression where the domain config option was set as required.
Add .codesandbox configs for easier PR reviews
Update README.md to reflect domain is optional for non-web-proxy sources.

Closes: #254

Before

domain Gatby config option was required, making it impossible to use absolute URLs.

After

domain Gatsby config option is optional, allowing folks to use absolute URLs with the plugin.
new unit test ensures there's no future regression

Steps to test

go to CodeSandbox
in test/dev-and-e2e/ edit the gatsby-config.js and remove the domain field
run yarn dev:start from the project root

Checklist

[x] Each commit follows the Conventional Commit spec format.
[ ] Update the readme (if applicable).
[x] All existing unit tests are still passing (if applicable).

[x] Add some steps so we can test your bug fix or feature (if applicable).
[x] Add new passing unit tests to cover the code introduced by your PR (if applicable).

imgix-git-robot commented 1 year ago

:tada: This PR is included in version 2.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: