search

imgix / imgix-csharp

A C# client library for generating image URLs with imgix
https://www.imgix.com
MIT License
15 stars 8 forks source link

fix: modify AssemblyInfo to reflect current version in ixlib param #22

Closed sherwinski closed 5 years ago

sherwinski commented 5 years ago

The ixlib parameter has not been reflecting the correct package version, despite the version being updated in Imgix.csproj. This PR modifies the AssemblyInfo.cs file to reflect the current package version, which is where the ixlib parameter value is generated from.

sherwinski commented 5 years ago

@zacman85 From what I gather, the package version in Imgix.csproj is the version reflected on Nuget -- but it seems like good practice to be updating the assembly version as well? In terms of this fix, do you think it's preferrable to generate the ixlib based on the csproj file, or should we keep both version numbers updated in either case?