This PR changes the default behavior of the single-argument
URLBuilder constructor. This change ensures that a default
constructed URLBuilder has its useHttps member variable
set to true so that urls are generated for the https scheme.
Change (Breaking)
This change in behavior represents a breaking change.
Before
Prior to this change, users could rely on a default-constructed URLBuilder's
useHttps member variable to be false. This meant that generated urls
would have their scheme set to "http" by default.
Now
Now, URLBuilder's useHttps member variable is set to true. This means
that generated urls now have their scheme set to "https".
Testing
three new tests have been added
one to test the default constructor (single-parameter)
constructs an https-url by default (by calling createUrl)
[x] this new test does fail before the breaking change
[x] this new test does pass after this breaking change
one to test that setUseHttps correctly sets false
one to test that setUseHttps correctly sets true
Misc
In the initial commit, IntelliJ tried to sneak in some spelling suggestions.
The suggested change was erroneously pushed with the above commit. IntelliJ was
right in that a change could/should be made.
An extra adoes improve the grammar of the exception message of which it is now part of.
We also took this opportunity to reformat the code base to indent files with spaces instead of tab characters (for more consistency).
feat(https): use https by default
Description
This PR changes the default behavior of the single-argument
URLBuilderconstructor. This change ensures that a default constructedURLBuilderhas itsuseHttpsmember variable set totrueso that urls are generated for the https scheme.Change (Breaking)
This change in behavior represents a breaking change.
Before
Prior to this change, users could rely on a default-constructed
URLBuilder'suseHttpsmember variable to befalse. This meant that generated urls would have their scheme set to "http" by default.Now
Now,
URLBuilder'suseHttpsmember variable is set totrue. This means that generated urls now have their scheme set to "https".Testing
createUrl)setUseHttpscorrectly setsfalsesetUseHttpscorrectly setstrueMisc
In the initial commit, IntelliJ tried to sneak in some spelling suggestions.
The suggested change was erroneously pushed with the above commit. IntelliJ was right in that a change could/should be made.
An extra
adoes improve the grammar of the exception message of which it is now part of.We also took this opportunity to reformat the code base to indent files with spaces instead of tab characters (for more consistency).