chore: transition to maven central for deploys

luqven commented 3 years ago

Description

This PR introduces gradle.build changes that should allow us to transition to publishing our library on the maven central repository.

uses nexus-publish-plugin to manage sonatype deployment needs
uses io.freefair.maven-central.validate-poms to validate generated pom.xml file matches MavenCentral specs
assumes certain environment variables are already set

commit-lint[bot] commented 3 years ago

Chore

transition to maven central for deploys (de2d930)
update build.grade to hit correct endpoints (6a9f43e)
add gradle-nexus-plugin capabilites (28eed4d)
sign files using env variables (a3c5817)
remove repo field and use env vars for auth (7160b5b)
change jdk version to 8 for travis compat (562887a)
update comments and add pom validation plugin (ec11624)
add comments to build.gradle explaining utf8 task (787a22c)

Documentation

add maven badge to README.md (ded32cc)

Contributors

luqven

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR

luqven commented 3 years ago

Tried every which way to change the gradle syntax to account for uploadArchives being deprecated but kept getting some very cryptic errors. For now, we have a build deployed to maven central (won't show up for another few hours) but this gradle script will stop working soonish. Next release might not be able to use it.

TDLR: we can now upload to maven central (once gradle.properties is defined locally) but this fix will not work long.

luqven commented 3 years ago

Somehow I've managed it. The entire build-deploy process is now handled in the build.gradle file. Some env variables are assumed.

luqven commented 3 years ago

And we're live on the sonatype maven central search 🎉

frederickfogerty commented 3 years ago

Congrats on this 👏

csummers commented 3 years ago

Just a note that the imgix-java-2.3.0.jar file currently on Maven Central only contains .java source files, and not compiled .class files, so I think something is missing here. Thanks!

luqven commented 3 years ago

Just a note that the imgix-java-2.3.0.jar file currently on Maven Central only contains .java source files, and not compiled .class files, so I think something is missing here. Thanks!

Hey csummers, thanks for reporting this. We're aware of the issue and it's a high priority for us to fix this. We'll share any updates we have here.

luqven commented 3 years ago

Cleaned up commits ☝🏼

For visibility, a fixed 2.3.0 release is now live

imgix / imgix-java