imgix / imgix-java

A Java client library for generating URLs with imgix
https://www.imgix.com
BSD 2-Clause "Simplified" License
19 stars 8 forks source link

fix(URLHelper): correctly encode more special chars #68

Closed luqven closed 3 years ago

luqven commented 3 years ago

Description

This PR adds more test cases for encoding paths in the URLHelper.java and fixes an issue where some special characters were not being encoded correctly.

This PR also re-enables formatOnSave for VSCode IDE to ensure style rulesets get enforced.

commit-lint[bot] commented 3 years ago

Chore

Tests

Bug Fixes

Lint

Contributors

luqven

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
luqven commented 3 years ago

@sherwinski @ericdeansanchez double checking we're good to merge this one in