Closed luqven closed 3 years ago
Latest build fails because of test testHelperBuildSignedURLWithWebProxyWithEncoding()
https://github.com/imgix/imgix-java/blob/c8e9655cdbcc7f0f937fce0f7fa62e740f3ba70a/src/test/java/com/imgix/test/TestAll.java#L173-L183
Maybe we need to allow encoded proxy paths through given this was established behavior? Might need to undo https://github.com/imgix/imgix-java/pull/70/commits/0c4f0d05584029326d06e163432503dd133c0eb7
Latest build fails because of test
testHelperBuildSignedURLWithWebProxyWithEncoding()
Maybe we need to allow encoded proxy paths through given this was established behavior? Might need to undo 0c4f0d0
Yeah I think you're right, we should keep this in order to prevent a breaking change.
@sherwinski @ericdeansanchez double checking we're good to merge this one in
@sherwinski @ericdeansanchez double checking we're good to merge this one in
All good from my end 👍
Had to force push since I forgot to rebase on luis/pathEncodingFix
before it got merged in to main. Apols.
Description
This PR adds test and updates the
sanitizePath
method to ensure Unicode characters get encoded when needed and as expected. It builds off of the imgix-go implementation for encoded URLs and creates a newisASCIIEncoded
method that validates ASCII encoding and a few more custom imgix encoding rules.