imgix / js-core

A JavaScript client library for generating image URLs with imgix
https://www.imgix.com
BSD 2-Clause "Simplified" License
122 stars 21 forks source link

(PoC) feat: add _buildSrcSet static method #288

Closed luqven closed 3 years ago

luqven commented 3 years ago

This PR is a WIP This PR is a stacked PR

PR Title Merges Into diff
1 _buildURL main review this
2 _buildSrcSet 👈🏼 #287 review this
3 fix extractUrl #288 review this

This PR adds a static method to ImgixClient, _buildSrcSet, that allow us to generate srcsets for 1-step, or full, URLs.

Future work

The type declarations make this more public than we may like. Could be in favor or removing them.

commit-lint[bot] commented 3 years ago

Features

Tests

Chore

Build System

Contributors

luqven

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
luqven commented 3 years ago

Closing in favor of #294