imgix / js-core

A JavaScript client library for generating image URLs with imgix
https://www.imgix.com
BSD 2-Clause "Simplified" License
122 stars 21 forks source link

fix: add missing types to `_buildSrcSet` type declaration #299

Closed luqven closed 3 years ago

luqven commented 3 years ago

Adds the following missing types to types/index.d.ts

// * @param {Object} srcsetModifiers - srcset modifiers, optional
// * @param {Object} clientOptions - imgix client options, optional

So that _buildSrcSet types are defined as

  static _buildSrcSet(
    path: string,
    params?: {},
    srcSetOptions?: {},
    clientOptions?: {},
  ): string;
commit-lint[bot] commented 3 years ago

Bug Fixes

Contributors

luqven

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
imgix-git-robot commented 3 years ago

:tada: This PR is included in version 3.3.1-rc.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: