Closed sylcastaing closed 2 years ago
@sylcastaing so I discussed with my team and we'd like to call the parameters devicePixelRatios
instead of targetDPRs
, and variableQualities
rather than targetDPRRatiosQualities
. This is the last change, and then we should be good to go!
@sylcastaing so I discussed with my team and we'd like to call the parameters
devicePixelRatios
instead oftargetDPRs
, andvariableQualities
rather thantargetDPRRatiosQualities
. This is the last change, and then we should be good to go!
Ok thanks !
I have time tomorrow morning (Paris TZ) to make the last changes
Merci @sylcastaing, ca sonne bien ! À demain 👋
I have push a new commit (not sure if the commit message is correct) with :
devicePixelRatios
and variableQualities
dist
file from PR
Description
This PR add 2 new options to control DPR
srcset
generation :targetDPRRatios
to generate DPR we need https://github.com/imgix/js-core/issues/304targetDPRRatiosQualities
to control image quality by DPR https://github.com/imgix/js-core/issues/284No breaking changes.
buildSrcSet
return the same as before if we don't provide this new options.Checklist: New Feature
chore(readme): fix typo
. See the end of this file for more information.BREAKING CHANGE
in the body of the commit.Steps to Test
targetDPRRatios
Result :
targetDPRRatiosQualities
Result :