imgix / js-core

A JavaScript client library for generating image URLs with imgix
https://www.imgix.com
BSD 2-Clause "Simplified" License
123 stars 21 forks source link

Latest @imgix/js-core does not work with Nuxt 3 #348

Closed oliver-heeger closed 1 year ago

oliver-heeger commented 1 year ago

@imgix/js-core does not work with latest stable Nuxt 3 version, as it uses an outdated version of ufo.
Multiple major versions of package ufo are being externalized. Picking latest version: ++ /home/projects/nuxt-starter-zucthe/node_modules/ufo@1.0.1 -- /home/projects/nuxt-starter-zucthe/node_modules/@imgix/js-core/node_modules/ufo@0.8.6

To Reproduce https://stackblitz.com/edit/nuxt-starter-zucthe

Steps to reproduce the behaviour:

  1. Go to https://stackblitz.com/edit/nuxt-starter-zucthe
  2. See error in console

Expected behaviour @imgix/js-core should not conflict with newer ufo versions.

Information:

luqven commented 1 year ago

Hey @oliver-heeger,

Thanks for opening this issue and drawing our attention to this. Dependabot stopped nagging us to update this dependency a few weeks back 🤦🏼 .

I've opened a PR to update ufo. Once someone has had a chance to review the PR, we can get this fix shipped.

imgix-git-robot commented 1 year ago

:tada: This issue has been resolved in version 3.7.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

luqven commented 1 year ago

Hey @oliver-heeger, js-ore v3.7.1 should have this fixed.

Should anything else come up, please don't hesitate to re-open this issue.

oliver-heeger commented 1 year ago

@luqven thanks, everything is fine now.