imgix / react-imgix

React component to display imgix images
https://www.npmjs.com/package/react-imgix
Other
360 stars 64 forks source link

SUPPORT-531 : Clarifies `Imgix` casing #946

Closed heyitsbryanm closed 8 months ago

heyitsbryanm commented 8 months ago

Description

Clarifies casing around Imgix by formatting it as a component. Also adds links to our rendering API.

When width and height are specified, Imgix will give the image a srcset with resolution descriptors.
When width and height are specified, `<Imgix>` will give the image a srcset with resolution descriptors.

Checklist

heyitsbryanm commented 8 months ago

For small readme changes like this, do we need to update and release a new version?

heyitsbryanm commented 8 months ago

Also, the tests are failing due to ChromeDriver

luqven commented 8 months ago

For small readme changes like this, do we need to update and release a new version?

No there's no need. We typically use docs: commit and let semantic-release take care of it anyway.

Right now the automated release step is having issues because of failing tests as you mentioned. I'll circle back on the failing CI steps next week.

heyitsbryanm commented 8 months ago

Wooo figured it out. It was an issue with browser-tools: https://github.com/cypress-io/circleci-orb/issues/446

I updated it in Arno's PR and that automerged it.

I rebased my branch and it's working here too now.

Merging.

luqven commented 8 months ago

Wooo figured it out. It was an issue with browser-tools

Perfect, and thanks for opening that PR. Approved!

imgix-git-robot commented 1 month ago

:tada: This PR is included in version 9.8.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: