search

imglib / imglib2-algorithm

Image processing algorithms for ImgLib2
http://imglib2.net/
Other
23 stars 20 forks source link

Add Hough transform #32

Closed panovr closed 6 years ago

panovr commented 7 years ago

This pull request is to port the Hough transform from ImgLib1 to ImgLib2, and also see this issue: https://github.com/imagej/imagej-ops/issues/465

axtimwalde commented 6 years ago

@ctrueden @hanslovsky the history of this pull request is painfully long and of limited educational value. It is certainly possible to ask @gselzer to rebase this post-fact into meaningful dissection supporting units but I also think that we all have a lot of stuff to do and this is not very helpful. I would therefore vote for squash and merge.

ctrueden commented 6 years ago

@axtimwalde I don't see why further rebasing would be needed. The commits are already small and clean and granular. It sounds like your beef is really just that there are a lot of them but I think that helps bisectability, rather than harming it. There are no harmful intermediate states, are there? Why not just merge it?

hanslovsky commented 6 years ago

@axtimwalde @tpietzsch Should I go ahead and squash and merge?

axtimwalde commented 6 years ago

@hanslovsky yes.

hanslovsky commented 6 years ago

Thanks @gselzer