search

imglib / imglib2-algorithm

Image processing algorithms for ImgLib2
http://imglib2.net/
Other
22 stars 20 forks source link

Update FloodFill interface #58

Closed hanslovsky closed 6 years ago

hanslovsky commented 6 years ago

Fixes #55

Current interface is not intuitive:

hanslovsky commented 6 years ago

@imglib/admins any objections against a merge?

Also, the newly deprecated methods should be considered for #61

tpietzsch commented 6 years ago

I had a very brief look and it looks good to me. Fine to merge it.

Independent of this fix, in the javadoc of generic parameters, I would say what they represent, not the restrictions. https://github.com/imglib/imglib2-algorithm/pull/58/files#diff-97cf72110dceb6de78c7e1473f2d8162R90

 * @param <T>
 *            T implements {@code Type<U>}.

just repeats (in this case wrong) what the method signature says anyways. Something like

 * @param <T>
 *            input pixel type.
 * @param <U>
 *            fill label type.

would be more helpful.

hanslovsky commented 6 years ago

Will update the JavaDoc and merge.