search

imglib / imglib2-algorithm

Image processing algorithms for ImgLib2
http://imglib2.net/
Other
22 stars 20 forks source link

Constrained Ransac based ellipse fitting, sphere fitting on 4 points #60

Closed kapoorlab closed 6 years ago

kapoorlab commented 6 years ago

Constrain Ransac to find ellipses on candidate points and determine their points of intersections, construct tangents at those points and determine the angle of intersection between the ellipses.

Fit 3D ellipsoids satisfying the same constraints.

Given 3/4 points, fit a Circle/sphere using yury petrov regression for local curvature measurements.

tpietzsch commented 6 years ago

This PR in src/main/java/subpixelLocalization/GaussianLineds.java contains copy-pasted GPL code. imglib-algorithm is BSD licensed, so this is not possible.

kapoorlab commented 6 years ago

I can remove the subpixel localization folder out of the repo, would that help?

hanslovsky commented 6 years ago

Please remove anything that would introduce an ImageJ dependency. As far as I can tell from the travis log, missing ij packages/classes is why the build fails. In general, ij should depend on imglib2-algorithm, not the other way around, cf #43

kapoorlab commented 6 years ago

I will make the changes to resolve the conflicts and then make a new pull request.

imagejan commented 6 years ago

@kapoorlab you can always force-push to your own topic branch to update the pull request. There should be no need to open a new one.