imglib / imglib2-algorithm

Image processing algorithms for ImgLib2
http://imglib2.net/
Other
22 stars 20 forks source link

Bump imglib2 dependency to 5.0.0 #64

Closed hanslovsky closed 6 years ago

hanslovsky commented 6 years ago

This bumps the imglib2 dependency to new major version 5. Only one test case needed adaption and all the tests succeed.

ctrueden commented 6 years ago

@hanslovsky @tpietzsch What are the backwards incompatible changes in imglib2 5.0.0? Has anyone run the melting pot on Fiji with imglib2 5.0.0 yet? Does anything break? (If not, I will do it during the SciView hackathon, since I will be improving the melting pot script and melting down Fiji repeatedly anyway to address other incompatibilities.)

hanslovsky commented 6 years ago

@ctrueden As far as I can tell, everything should be pretty smooth as long as you use imglib2 primitive type equivalents (ByteType etc). I am updating all projects that I depend on to figure out what kind of problems we may run into. So far I have done the update for

It is probably good advise to keep all these PRs/branches open for a while before merging into the respective master branches.

hanslovsky commented 6 years ago

See also imglib/imglib2#204

hanslovsky commented 6 years ago

Fixed in 97360f3653d4eb661dae2e84924ddcdb291f3200