Closed jdeschamps closed 1 year ago
Right now this PR has to wait for the resolution of https://github.com/imglib/imglib2-roi/pull/59 !
edit: imglib/imglib2-roi#59 has been merged
New commits:
This PR is dependent on imglib2-roi 0.11.1-SNAPSHOT (currently 0.10.4 in the scijava-pom 30.0.0 and 0.11.0 in the scijava-pom 32.0.0-SNAPSHOT)
@tpietzsch Any news on this front? :D
@jdeschamps I rebased on current master (3dcd24c89176d3806fd12d0334da442a968feb0c) and added a few easy simplifications. I will add more comments inline, but I think in principle this is fine as it is. Simplifications/optimizations can be made later.
The only real problem I see is MunkresKuhnAlgorithm
(adapted from trackmate) which is under GPL license. This is incompatible with the BSD license of imglib2-algorithm. So either
MultiMetrics
, LazyMultiMetrics
that use it) should be moved to imglib2-algorithm-gpl, orWhatever you prefer.
I get that!
I'd be in favor of relicensing. We should then ask @dscho whether he agrees to relicense MunkresKuhnAlgorithm.java from GPLv3 to BSD.
Do you know from the top of your head an alternative implementation? Otherwise I'd wait a bit and start looking for one in case @dscho disagrees.
I am fine with the proposed relicensing!
Awesome! Thank you Johannes! @dscho
finally...
A bunch of classes to compute image quality or segmentation metrics between two RAI. The results have been checked against original implementations (Cell Tracking Challenge, StarDist) or widely used librairies (scikit-image).
Image Quality:
Segmentation: