Remove code duplication in ImagePlusImg implementations.

imglib / imglib2-ij

Translation between ImgLib & ImageJ data structures (both 1.x and 2)

Other

4 stars 8 forks source link

Remove code duplication in ImagePlusImg implementations. #14

Closed maarzt closed 6 years ago

maarzt commented 6 years ago

This PR is pure refactoring, no behavior of any class is changed.

A lot of code duplication is removed be introducing a new class AbstractImagePlusImg.

ctrueden commented 6 years ago

I think this PR is great. I only have one concern, which is that the new AbstractImagePlusImg extends ImagePlusImg, which is counterintuitive naming-wise. Since ImagePlusImg has only non-public constructors, why not make ImagePlusImg abstract and include the shared code directly there instead?

tpietzsch commented 6 years ago

I merged locally and pushed to master