search

imglib / imglib2-ij

Translation between ImgLib & ImageJ data structures (both 1.x and 2)
Other
4 stars 8 forks source link

ImageJVirtualStackFloat: Don't compute minmax #4

Closed hinerm closed 9 years ago

hinerm commented 9 years ago

Avoids iteration of the dataset when creating ImageJVirtualStackFloat instances.

hinerm commented 9 years ago

@tpietzsch Is this alright?

tpietzsch commented 9 years ago

@hinerm Float.MIN_VALUE is the smallest positive nonzero value of type float, i.e., not the same concept as Integer.MIN_VALUE. It should be either Float.NEGATIVE_INFINITY to Float.POSITIVE_INFINITY, or -Float.MAX_VALUE to Float.MAX_VALUE, or maybe just 0 to 1.

hinerm commented 9 years ago

ah of course; sorry, forgot. I like NEGATIVE_INFINITY/POSITIVE_INFINITY personally.. updated

tpietzsch commented 9 years ago

thanks @hinerm

hinerm commented 9 years ago

thanks @tpietzsch ! :octopus: