Import the algorithms present in imagej-ops

imglib / imglib2-mesh

Proposal for a Java mesh library built from code from imagej-mesh and imagej-ops.

BSD 2-Clause "Simplified" License

4 stars 0 forks source link

Import the algorithms present in imagej-ops #1

Closed tinevez closed 1 year ago

tinevez commented 1 year ago

This break the separation between the data structure and the algorithms. But there are reasons why we want to do this:

facilitate development of data structures without breaking ops
offer to consumers one lib that has algos and data structures
offer consumers not to have to pull all imagej-ops if they just want to play with meshes
if there will be an imagej-ops2, then it can have default implementations that link to the algos in this lib, instead of copying the code from imagej-ops1.

tinevez commented 1 year ago

thank you @ctrueden ! I implemented most of your suggestions.

I could not find a good way to change the design as you suggested, that is: have method that produce a new mesh accepts a pre-allocated Mesh object that they mutate. The main mesh implementation we use is the BufferMesh (e.g. in the BVV), which requires the number of vertices and triangles to be stored to be known in advance.

tinevez commented 1 year ago

Also: careful I git-push-forced.